fix: env vars to tune cluster cache were broken #7779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Suen <jesse@akuity.io>
Codecov Report
@@ Coverage Diff @@
## master #7779 +/- ##
=======================================
Coverage 41.43% 41.43%
=======================================
Files 163 163
Lines 22082 22082
=======================================
Hits 9150 9150
Misses 11629 11629
Partials 1303 1303
Continue to review full report at Codecov.
|
alexmt
approved these changes
Nov 25, 2021
jessesuen
added a commit
that referenced
this pull request
Nov 25, 2021
Signed-off-by: Jesse Suen <jesse@akuity.io>
alexmt
pushed a commit
that referenced
this pull request
Nov 30, 2021
Signed-off-by: Jesse Suen <jesse@akuity.io>
roi-codefresh
added a commit
to codefresh-io/argo-cd
that referenced
this pull request
Feb 6, 2022
* fix(ui): Add Error Boundary around Extensions and comply with new Extensions API (argoproj#7215) * fix: Add error boundary around Extensions and change path where UI looks for extensions Signed-off-by: Remington Breeze <remington@breeze.software> * Add error message to error boundary Signed-off-by: Remington Breeze <remington@breeze.software> * docs: Kustomize load_restrictor -> load-restrictor (argoproj#7358) Signed-off-by: Jan-Otto Kröpke <joe@adorsys.de> * docs: update v2.3+ roadmap (argoproj#7353) * docs: update v2.3+ roadmap Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Address reviewer notes: Add 'Merge Argo CD Image Updater into Argo CD' and 'Multi-tenancy improvements' Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: remove not existing repo (argoproj#7280) * remove not existing repo Signed-off-by: pashavictorovich <pavel@codefresh.io> * fix test Signed-off-by: pashavictorovich <pavel@codefresh.io> * fix: Application status panel shows Syncing instead of Deleting (argoproj#7486) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: Operation has completed with phase: Running (argoproj#7482) * fix: Operation has completed with phase: Running Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.1.4 * Bump version to 2.1.4 * fix: Invalid memory address or nil pointer dereference in processRequestedAppOperation (argoproj#7501) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.1.5 * Bump version to 2.1.5 * fix: supporting OCI dependencies. Fixes argoproj#6062 (argoproj#6994) * fix: supporting OCI dependencies Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com> * chore: add org to USERS.md Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com> * fix(tests): remove invalid TestRepoPermission e2e test Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com> * fix: don't use revision caching during app creation (argoproj#7508) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.1.6 * Bump version to 2.1.6 * Fix: Kuberenetes manifest to have new Github.com ssh known host keys for ArgoCD deployments (argoproj#7722) * Kuberenetes manifest to have new ssh known host keys for ArgoCD deployments https://github.blog/2021-09-01-improving-git-protocol-security-github/ Signed-off-by: smark88 <msarcevicz@influxdata.com> * added to docs Signed-off-by: smark88 <msarcevicz@influxdata.com> * fix: regenerate manifests using 'make manifests' Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Bump version to 2.1.7 * Bump version to 2.1.7 * fix: upgraded gitops engine to v0.4.2 (fixes argoproj#7561) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * fix: env vars to tune cluster cache were broken (argoproj#7779) Signed-off-by: Jesse Suen <jesse@akuity.io> * fix nil point (argoproj#7905) Signed-off-by: jomenxiao <jomenxiao@gmail.com> * fix: issue with keepalive (argoproj#7861) * fix issue with keepalive Signed-off-by: pashavictorovich <pavel@codefresh.io> * empty commit Signed-off-by: pashavictorovich <pavel@codefresh.io> * Bump version to 2.1.8 * Bump version to 2.1.8 * Merge pull request from GHSA-63qx-x74g-jcr7 Signed-off-by: jannfis <jann@mistrust.net> * Bump version to 2.1.9 * Bump version to 2.1.9 * fix: Resolve symlinked value files correctly (argoproj#8387) * fix: Resolve symlinked value files correctly Signed-off-by: jannfis <jann@mistrust.net> * fix: Resolve symlinked value files correctly Signed-off-by: jannfis <jann@mistrust.net> * Bump version to 2.1.10 * Bump version to 2.1.10 * add CODEFRESH=true to e2e workflow * codegen * fix e2e Co-authored-by: Remington Breeze <remington@breeze.software> Co-authored-by: Jan-Otto Kröpke <github@jkroepke.de> Co-authored-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io> Co-authored-by: argo-bot <argoproj@gmail.com> Co-authored-by: Mohammad Yosefpor <47300215+m-yosefpor@users.noreply.github.com> Co-authored-by: Mark Sarcevicz <47335998+smark88@users.noreply.github.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Jesse Suen <jessesuen@users.noreply.github.com> Co-authored-by: jomenxiao <jomenxiao@gmail.com> Co-authored-by: jannfis <jann@mistrust.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following env vars to tune the cluster cache never worked because we were checking for error when parsing the env var, we should have been checking for success:
ARGOCD_K8S_CLIENT_QPSARGOCD_K8S_CLIENT_BURSTARGOCD_K8S_CLIENT_MAX_IDLE_CONNECTIONSSigned-off-by: Jesse Suen jesse@akuity.io