Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app list and details page specific views to navigation history (regression in behavior) #7776

Closed
2 of 3 tasks
keithchong opened this issue Nov 24, 2021 · 3 comments · Fixed by #7937
Closed
2 of 3 tasks
Assignees
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@keithchong
Copy link
Contributor

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

I was selecting the various views in the details page and when I pressed the browser's Back button, it brought me back to the Application list page. Before, it would just switch back to the Details-specific view that I had just visited. The change for this was due to #7090.

IMHO, while I do agree that the sliding panels should not be part of the navigation history, I think the fix for this went a bit too far in removing the views from the history. The buttons along the left side-bar are part of the history at least.

To Reproduce

  1. Go to https://cd.apps.argoproj.io/applications?proj=&sync=&health=&namespace=&cluster=&labels=
  2. Click on one of the apps to drill down to its details page
  3. Select several views, eg. Pods, Network, List and Tree views in succession
  4. Press the browser's Back button
    --> you will go back to the Application List page

Expected behavior

These views should be part of the navigation history

Just to compare:

  • Simply look at the current github page, select the various tabs above (Issues, Pull requests, Discussions) - they are part of the navigation history
  • Amazon navigation 'tabs' as well
  • Walmart navigation tabs
  • (not that I'm checking out Black Friday sales or anything....)
  • Go to the fluxcd.io page and click on the top right menus

Version
Latest

@keithchong keithchong added bug Something isn't working component:ui User interfaces bugs and enhancements labels Nov 24, 2021
@keithchong keithchong changed the title Add app list and details page specific views to navigation history Add app list and details page specific views to navigation history (regression in behavior) Nov 24, 2021
@keithchong
Copy link
Contributor Author

Hi @pasha-codefresh, I can take this.

@keithchong keithchong self-assigned this Nov 25, 2021
@keithchong
Copy link
Contributor Author

keithchong commented Nov 25, 2021

See argoproj/argo-ui#164. The second part in argo-cd will follow

@pasha-codefresh
Copy link
Member

Thank you @keithchong

keithchong added a commit to keithchong/argo-cd that referenced this issue Jan 10, 2022
keithchong added a commit to keithchong/argo-cd that referenced this issue Jan 10, 2022
keithchong added a commit to keithchong/argo-cd that referenced this issue Jan 14, 2022
alexmt pushed a commit that referenced this issue Jan 14, 2022
… (#7937)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants