Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to customise values section when deploying a helm chart #8013

Closed
mcbenjemaa opened this issue Dec 22, 2021 · 3 comments
Closed

Ability to customise values section when deploying a helm chart #8013

mcbenjemaa opened this issue Dec 22, 2021 · 3 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@mcbenjemaa
Copy link

mcbenjemaa commented Dec 22, 2021

Summary

I want to customise and patch argocd application resources using kustomize,
there's no support for patching values because spec.source.helm.values is a string.

The only way is to patch with spec.source.helm.parameters but that's annoying when you have many nested values.

Motivation

I'm maintaining apps of apps for many platforms, and I would avoid DRY.

Using kustomize to customise my apps in different platforms/ and environments without the need to replicate manifests. single source of truth for my platforms.

Proposal

How do you think this should be implemented?

Add a field that holds values as raw yaml instead of string (make it backward compatible of course!)

I was assuming that argocd application has a field that supports yaml (like crossplane provider helm does https://github.com/crossplane-contrib/provider-helm/blob/master/apis/release/v1beta1/types.go#L71)

This is a super important feature!

@mcbenjemaa mcbenjemaa added the enhancement New feature or request label Dec 22, 2021
@Joibel
Copy link
Member

Joibel commented Dec 24, 2021

This is the problem I have written https://github.com/crumbhole/argocd-lovely-plugin to solve for myself.

@joggeli34
Copy link

This would also be handy for changing the values with yq more easily. We are using this to change the image tags when releasing a new image directly from a ci/cd pipeline.

@crenshaw-dev
Copy link
Member

Closing in favor of duplicate #2936

@crenshaw-dev crenshaw-dev added the duplicate This issue or pull request already exists label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants