Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide address flag for admin dashboard command #8095

Merged
merged 2 commits into from Jan 7, 2022
Merged

Provide address flag for admin dashboard command #8095

merged 2 commits into from Jan 7, 2022

Conversation

avinashupadhya99
Copy link
Contributor

@avinashupadhya99 avinashupadhya99 commented Jan 5, 2022

Closes #7891

image
image

The only issue with this implementation is that the server that is created after the dashboard server also uses the same address for listening. In the above netstat output, the server running on port 45633 also uses 0.0.0.0. In the previous implementation, every server runs on localhost.

image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Avinash Upadhyaya <avinashupadhya99@gmail.com>
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #8095 (8d351bf) into master (4a55b13) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8095      +/-   ##
==========================================
- Coverage   41.53%   41.51%   -0.02%     
==========================================
  Files         174      174              
  Lines       22703    22712       +9     
==========================================
  Hits         9430     9430              
- Misses      11932    11941       +9     
  Partials     1341     1341              
Impacted Files Coverage Δ
cmd/argocd/commands/admin/dashboard.go 0.00% <0.00%> (ø)
cmd/argocd/commands/headless/headless.go 3.48% <0.00%> (-0.13%) ⬇️
cmd/argocd/commands/root.go 2.08% <0.00%> (ø)
server/application/application.go 32.65% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a55b13...8d351bf. Read the comment docs.

@avinashupadhya99
Copy link
Contributor Author

Are the docs auto-generated? Should I revert my commit of changing the docs?

@alexmt
Copy link
Collaborator

alexmt commented Jan 6, 2022

Thank you for PR @avinashupadhya99 ! Looks good to me.

Yes, CLI docs are autogenerated. Please run make clidocsgen to regenerate them and PR it good to go.

Signed-off-by: Avinash Upadhyaya <avinashupadhya99@gmail.com>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@alexmt alexmt merged commit 8b57bc9 into argoproj:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configurable listen address for argocd admin dashboard
2 participants