Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route health check stuck in 'Progressing' #8170

Merged
merged 1 commit into from Jan 14, 2022

Conversation

ishitasequeira
Copy link
Member

Signed-off-by: Ishita Sequeira

Fixes #8144

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #8170 (5be6fe0) into master (5c85df9) will not change coverage.
The diff coverage is n/a.

❗ Current head 5be6fe0 differs from pull request most recent head 8ff687c. Consider uploading reports for the commit 8ff687c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8170   +/-   ##
=======================================
  Coverage   41.53%   41.53%           
=======================================
  Files         174      174           
  Lines       22629    22629           
=======================================
  Hits         9399     9399           
  Misses      11897    11897           
  Partials     1333     1333           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c85df9...8ff687c. Read the comment docs.

Signed-off-by: ishitasequeira <isequeir@redhat.com>
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ishitasequeira

@jannfis jannfis added the cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch label Jan 14, 2022
@jannfis jannfis merged commit 55ea342 into argoproj:master Jan 14, 2022
jannfis pushed a commit that referenced this pull request Jan 14, 2022
Signed-off-by: ishitasequeira <isequeir@redhat.com>
@jannfis
Copy link
Member

jannfis commented Jan 14, 2022

Cherry picked to release-2.2: c3144c0

@jacksgt
Copy link
Contributor

jacksgt commented Jan 24, 2022

@ishitasequeira Great, thanks for this!
I just came across this issue when upgrading my cluster to v2.2, and it's amazing to see it's already fixed. :-)

cyrilix pushed a commit to cyrilix/argo-cd that referenced this pull request Feb 15, 2022
Signed-off-by: ishitasequeira <isequeir@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.2 Candidate for cherry picking into the 2.2 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

route.openshift.io/v1 resource Health stuck in "Progressing" with details "Route is still getting admitted"
3 participants