Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for using private repos in AppSet tests #8967

Closed
crenshaw-dev opened this issue Apr 1, 2022 · 4 comments
Closed

Add test for using private repos in AppSet tests #8967

crenshaw-dev opened this issue Apr 1, 2022 · 4 comments
Assignees
Labels
component:application-sets Bulk application management related component:test Test requests (e2e or unit) enhancement New feature or request

Comments

@crenshaw-dev
Copy link
Member

Summary

We need tests to show that the ApplicationSet controller can handle private repositories.

Motivation

When ApplicationSet was merged with Argo CD, I think we upgraded to the new credentials passing mechanism without ensuring that it was working. I think we need the AppSet controller to run the git-ask-pass server.

Proposal

Copy patterns from the already-existing Argo CD tests for private repos.

@crenshaw-dev crenshaw-dev added the enhancement New feature or request label Apr 1, 2022
@iam-veeramalla
Copy link
Member

@rishabh625 do you want to work on this or through some input for the tests ?

@rishabh625
Copy link
Contributor

Oh yeah that I missed. thanks!!! @iam-veeramalla for bringing it to my notice as i m not following argocd,

Yeah I'll add the tests tysm

@iam-veeramalla iam-veeramalla added the component:test Test requests (e2e or unit) label Apr 1, 2022
@crenshaw-dev crenshaw-dev added the component:application-sets Bulk application management related label Apr 1, 2022
@rishabh625
Copy link
Contributor

Currently private repo in git generator is not working, as askpass method for credentials was used without starting server. If we start the askpass server , private repo in git generator works good. Problem is with e2e tests since e2e test share same os and filesystem starting a new server in appset overwrites the sock file and askpass mechanism doesn't work in repo server. m unsure of how to proceed on. Related PR

@rishabh625
Copy link
Contributor

rishabh625 commented May 4, 2022

plz close as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:application-sets Bulk application management related component:test Test requests (e2e or unit) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants