Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing Default Metric Port for ApplicationSet Controller in Manifest Files #8999

Closed
hcelaloner opened this issue Apr 5, 2022 · 1 comment · Fixed by #9000
Closed

Exposing Default Metric Port for ApplicationSet Controller in Manifest Files #8999

hcelaloner opened this issue Apr 5, 2022 · 1 comment · Fixed by #9000
Assignees
@hcelaloner @iam-veeramalla
Labels
enhancement New feature or request

Comments

@hcelaloner
Copy link
Contributor

Summary

Out of the box, ApplicationSet presents some controller-runtime metrics on port 8080. However, the metric port is not defined as a container port in manifest files, therefore, they are not accessible. By default, can we make it accessible?

Proposal

By default, define it as a port definition in the manifest port.

Note: Copy of argoproj/applicationset#495 since applicationset repo moved into argocd
@hcelaloner hcelaloner added the enhancement New feature or request label Apr 5, 2022
@hcelaloner hcelaloner mentioned this issue Apr 5, 2022
Merged
10 tasks
@iam-veeramalla
Copy link
Member

@hcelaloner Thanks for raising the issue as well as PR. I have assigned the issue to your name. I hope you are okay with it :)

crenshaw-dev pushed a commit that referenced this issue Apr 7, 2022
@hcelaloner @erkanzileli
feat: Exposing Default Metric Port for ApplicationSet Controller in M…
21f0aa3 
…anifest Files. #8999 (#9000)

* feat: expose default metrics port in manifest definitions.

Out of the box, Applicationset presents some controller-runtime metrics on port 8080. However, the metric port is not defined as a container port in manifest files, therefore, they are not accessible. This
commit aims to make it accessible.

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* chore: add Trendyol to the list of users.

Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* chore(docs): add ServiceMonitor manifest example for newly added metrics.

Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* fix: regenerate manifest file via make file.

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
Signed-off-by: Celal Öner <celal.oner@trendyol.com>

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Apr 9, 2022
@hcelaloner @erkanzileli
feat: Exposing Default Metric Port for ApplicationSet Controller in M…
8e54042 
…anifest Files. argoproj#8999 (argoproj#9000)

* feat: expose default metrics port in manifest definitions.

Out of the box, Applicationset presents some controller-runtime metrics on port 8080. However, the metric port is not defined as a container port in manifest files, therefore, they are not accessible. This
commit aims to make it accessible.

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* chore: add Trendyol to the list of users.

Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* chore(docs): add ServiceMonitor manifest example for newly added metrics.

Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* fix: regenerate manifest file via make file.

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
Signed-off-by: Celal Öner <celal.oner@trendyol.com>

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
Signed-off-by: asingh51 <Ashutosh_Singh@intuit.com>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this issue Apr 25, 2022
@hcelaloner @erkanzileli @wojtekidd
feat: Exposing Default Metric Port for ApplicationSet Controller in M…
c159cbd 
…anifest Files. argoproj#8999 (argoproj#9000)

* feat: expose default metrics port in manifest definitions.

Out of the box, Applicationset presents some controller-runtime metrics on port 8080. However, the metric port is not defined as a container port in manifest files, therefore, they are not accessible. This
commit aims to make it accessible.

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* chore: add Trendyol to the list of users.

Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* chore(docs): add ServiceMonitor manifest example for newly added metrics.

Signed-off-by: Celal Öner <celal.oner@trendyol.com>

* fix: regenerate manifest file via make file.

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
Signed-off-by: Celal Öner <celal.oner@trendyol.com>

Co-authored-by: Erkan Zileli <erkan.zileli@trendyol.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hcelaloner hcelaloner

@iam-veeramalla iam-veeramalla

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@hcelaloner @iam-veeramalla