Support GitHub App In ApplicationSet Pull Request generator

[agaudreault]

Summary

The Pull Request generator of the ApplicationSet only supports a Personal Access Token in the tokenRef. ArgoCD already have the logic to authenticate with a GitHub App.

Motivation

Using a GitHub App is more secure and allows for more rate limits

Proposal

Reference to a secret containing the GitHub App information in the format already defined by ArgoCD

  - pullRequest:
      github:
        owner: org
        repo: repo
        # Reference to a Secret containing github app information. (optional)
        appRef:
          secretName: github-app
        # Labels is used to filter the PRs that you want to target. (optional)
        labels:
          - preview

[BeyerJC]

I opened the same proposal in the application controller repo --> argoproj/applicationset#565

Would be a great feature !

[iamstarkov]

and it would be great to support GitHub App In ApplicationSet SCM generator too

[iamstarkov]

@BeyerJC applicationset repo is deprecated afaik

[iamstarkov]

FYI #10092