feat: parameterized config management plugins (#9135)

[crenshaw-dev]

To test:

1. checkout this branch and build the image

make image IMAGE_TAG=param

2. add the following files to the manifests directory:

a. kustomization.yaml

resources:
  - install.yaml
  - resources.yaml

patchesStrategicMerge:
  - patches.yaml

images:
  - name: quay.io/argoproj/argocd
    newName: argocd
    newTag: param

b. patches.yaml

apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app.kubernetes.io/name: argocd-repo-server
    app.kubernetes.io/part-of: argocd
    app.kubernetes.io/component: repo-server
  name: argocd-repo-server
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: argocd-repo-server
  template:
    metadata:
      labels:
        app.kubernetes.io/name: argocd-repo-server
    spec:
      serviceAccountName: argocd-repo-server
      automountServiceAccountToken: false
      containers:
        - name: my-plugin
          command: [/var/run/argocd/argocd-cmp-server]
          image: busybox
          securityContext:
            runAsNonRoot: true
            runAsUser: 999
          volumeMounts:
            - mountPath: /var/run/argocd
              name: var-files
            - mountPath: /home/argocd/cmp-server/plugins
              name: plugins
            - mountPath: /home/argocd/cmp-server/config/plugin.yaml
              subPath: plugin.yaml
              name: my-plugin-config
      volumes:
        - configMap:
            name: my-plugin-config
          name: my-plugin-config
        - emptyDir: {}
          name: cmp-tmp

c. resources.yaml

apiVersion: v1
kind: ConfigMap
metadata:
  name: my-plugin-config
data:
  plugin.yaml: |
    apiVersion: argoproj.io/v1alpha1
    kind: ConfigManagementPlugin
    metadata:
      name: my-plugin
    spec:
      version: v1.0
      generate:
        command: [sh, -c, 'echo "{\"kind\": \"ConfigMap\", \"apiVersion\": \"v1\", \"metadata\": { \"name\": \"$ARGOCD_APP_NAME\", \"namespace\": \"$ARGOCD_APP_NAMESPACE\", \"annotations\": {\"Foo\": \"$FOO\", \"KubeVersion\": \"$KUBE_VERSION\", \"KubeApiVersion\": \"$KUBE_API_VERSIONS\",\"Bar\": \"baz\"}}}"']
      discover:
        fileName: "./subdir/s*.yaml"
      parameters:
        static:
          - name: string-param
            string: default-string-value
          - name: array-param
            array: [default, items]
            collectionType: array
          - name: map-param
            map:
              some: value
            collectionType: map
---
apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: plugin-test-app
spec:
  project: default
  source:
    repoURL: https://github.com/crenshaw-dev/plugin-test-app.git
    path: .
    plugin:
      env:
        - name: FOO
          value: bar
        - name: REV
          value: test-$ARGOCD_APP_REVISION
      parameters:
        - name: array-param
          array:
            - override
            - values
  destination:
    namespace: default
    server: https://kubernetes.default.svc

3. apply the manifests to docker-desktop or minikube

# the sed part makes sure you pull the locally-built image
kustomize build manifests | sed 's/imagePullPolicy: Always/imagePullPolicy: Never/g' | kubectl apply -n argocd -f -

4. port-forward and tinker

kubectl port-forward svc/argocd-server -n argocd 8080:443

https://localhost:8080

There will be an Application called plugin-test-app. You'll be able to see its parameters in the Application panel's "Parameters" tab and in the "Manifest" tab.

Closes #9135

[crenshaw-dev]

Not actually ready for review, I just want to see if it'll generate a codecov diff for me.

[codecov]

Codecov Report

Base: 46.70% // Head: 46.88% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (69367dc) compared to base (752bc5f).
Patch coverage: 52.40% of modified lines in pull request are covered.

❗ Current head 69367dc differs from pull request most recent head e6164cd. Consider uploading reports for the commit e6164cd to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9216      +/-   ##
==========================================
+ Coverage   46.70%   46.88%   +0.17%     
==========================================
  Files         240      240              
  Lines       39771    39907     +136     
==========================================
+ Hits        18577    18712     +135     
+ Misses      19310    19303       -7     
- Partials     1884     1892       +8     

Impacted Files	Coverage Δ
cmpserver/plugin/config.go	31.42% <ø> (ø)
util/app/discovery/discovery.go	41.07% <0.00%> (ø)
reposerver/repository/repository.go	59.83% <23.33%> (-1.64%)	⬇️
util/cmp/stream.go	50.94% <39.13%> (-0.04%)	⬇️
cmpserver/plugin/plugin.go	80.15% <67.53%> (+29.90%)	⬆️
pkg/apis/application/v1alpha1/types.go	58.18% <88.46%> (+0.76%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[leoluz]

Please check my comments. No major issue found.
We are missing the functionality to provide parameters from Argo CD UI as well as from the CLI. See argocd app set --help

[crenshaw-dev]

@leoluz PTAL

[leoluz]

LGTM!