Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: New connector layout not applied to load balancer in network view; expansion icon should not appear in one scenario #9452

Closed
3 tasks
keithchong opened this issue May 18, 2022 · 1 comment · Fixed by #9523
Closed
3 tasks

UI: New connector layout not applied to load balancer in network view; expansion icon should not appear in one scenario #9452

keithchong opened this issue May 18, 2022 · 1 comment · Fixed by #9523
Assignees
@keithchong
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@keithchong
Copy link
Contributor

keithchong commented May 18, 2022 •
edited

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

The recent enhancements to the graphical tree views have been merged (#8661). The connections from a load balancer does not have the new line layout. Also, in one case, the expansion icon appears on a node when it should not. See screenshots.

To Reproduce

Go the network view of the argo-cd app

Expected behavior

Screenshots

argo-cd-app

In the following service, the expansion icon should not appear. (Need to investigate why)
ExpansionIconAppears

Version

{
"Version": "v2.4.0+a809469",
"BuildDate": "2022-05-18T11:37:59Z",
"GitCommit": "a809469d9af10c626449bfcb8b9a09a9d2dc9065",
"GitTreeState": "clean",
"GoVersion": "go1.18.2",
"Compiler": "gc",
"Platform": "linux/amd64",
"KustomizeVersion": "v4.4.1 2021-11-11T23:36:27Z",
"HelmVersion": "v3.8.1+g5cb9af4",
"KubectlVersion": "v0.23.1",
"JsonnetVersion": "v0.18.0"
}
@keithchong keithchong added the bug Something isn't working label May 18, 2022
@keithchong keithchong self-assigned this May 18, 2022
@keithchong keithchong changed the title UI: New connector layout not applied to load balancer; expansion icon should not appear on pod group UI: New connector layout not applied to load balancer; expansion icon should not appear in one scenario May 18, 2022
@keithchong keithchong added the component:ui User interfaces bugs and enhancements label May 18, 2022
@keithchong keithchong changed the title UI: New connector layout not applied to load balancer; expansion icon should not appear in one scenario UI: New connector layout not applied to load balancer in network view; expansion icon should not appear in one scenario May 19, 2022
@keithchong
Copy link
Contributor Author

With fix:

WithFix

keithchong added a commit to keithchong/argo-cd that referenced this issue May 26, 2022
@keithchong
fix: New line layout not applied to load balancer; podGroup fix (argo…
af87f13 
…proj#9452)

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong mentioned this issue May 26, 2022
Merged
10 tasks
rbreeze pushed a commit that referenced this issue May 27, 2022
@keithchong
fix: New line layout not applied to load balancer; podGroup fix (#9452)…
a7dac14 
… (#9523)

Signed-off-by: Keith Chong <kykchong@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithchong keithchong

Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: New line layout not applied to load balancer; podGroup fix (#9452) keithchong/argo-cd
1 participant
@keithchong