fix: New line layout not applied to load balancer; podGroup fix (#9452)

[keithchong]

Signed-off-by: Keith Chong kykchong@redhat.com

Fixes #9452

See screenshots in issue. The original implementation didn't account for load balancers. Note that on line 891, the loadBalancerNodeKey is:

const loadBalancerNodeKey = ${EXTERNAL_TRAFFIC_NODE}:${key};

The fix uses this prefix as the identifier.

The other fix is for podGroups that are roots which was not accounted for in the original implementation.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

Screenshots of fix:

[codecov]

Codecov Report

Merging #9523 (af87f13) into master (f831c07) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9523      +/-   ##
==========================================
+ Coverage   45.77%   45.84%   +0.07%     
==========================================
  Files         221      221              
  Lines       26284    26300      +16     
==========================================
+ Hits        12031    12057      +26     
+ Misses      12599    12589      -10     
  Partials     1654     1654              

Impacted Files	Coverage Δ
server/application/terminal.go	24.32% <0.00%> (+16.74%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f831c07...af87f13. Read the comment docs.

[ciiay]

Tested and LGTM.

[keithchong]

Hi @rbreeze, @ciiay reviewed this. This is a small change. Please review, for your awareness.

[rbreeze]

LGTM!