Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added the ability to filter MRs by 'state' to Gitlab PR Generator #9540

Merged
merged 2 commits into from Jun 8, 2022
Merged

feat: Added the ability to filter MRs by 'state' to Gitlab PR Generator #9540

merged 2 commits into from Jun 8, 2022

Conversation

Aym3nTN
Copy link
Contributor

@Aym3nTN Aym3nTN commented May 30, 2022 •
edited

Signed-off-by: Aymen Ben Tanfous aymen.bentanfous@cimpress.com

Closes: #9539

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented May 30, 2022 •
edited

Codecov Report

Merging #9540 (5a55431) into master (42bf090) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master    #9540   +/-   ##
=======================================
  Coverage   45.89%   45.90%           
=======================================
  Files         222      222           
  Lines       26458    26461    +3     
=======================================
+ Hits        12143    12146    +3     
  Misses      12658    12658           
  Partials     1657     1657
Impacted Files Coverage Δ
applicationset/generators/pull_request.go 42.46% <0.00%> (ø)
...is/applicationset/v1alpha1/applicationset_types.go 34.69% <ø> (ø)
applicationset/services/pull_request/gitlab.go 86.48% <100.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bf090...5a55431. Read the comment docs.

crenshaw-dev
crenshaw-dev reviewed Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add a line to the docs mentioning the filter?

Aymen Ben Tanfous added 2 commits June 8, 2022 17:54
@Aym3nTN
Added the ability to filter MRs by 'state' to Gitlab PR Generator
8b355c7 
Simplied state verification + Added Unit test

Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
@Aym3nTN
Updated the doc
5a55431 
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) June 8, 2022 16:59
@crenshaw-dev crenshaw-dev merged commit 8a1d9fe into argoproj:master Jun 8, 2022
@Aym3nTN
Copy link
Contributor Author

Aym3nTN commented Jun 8, 2022 •
edited

@crenshaw-dev would this feat and this one #9462 be release in the next release? I'm not yet familiar with the release way and cadence in argo project.

@crenshaw-dev
Copy link
Collaborator

@Aym3nTN this will be in 2.5, which is expected in August.

Aym3nTN added a commit to Aym3nTN/argo-cd that referenced this pull request Sep 15, 2022
@Aym3nTN
feat: Added the ability to filter MRs by 'state' to Gitlab PR Generat…
b992ce8 
…or (argoproj#9540)

* Added the ability to filter MRs by 'state' to Gitlab PR Generator
Simplied state verification + Added Unit test

Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>

* Updated the doc

Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>

Co-authored-by: Aymen Ben Tanfous <aymen.bentanfous@cimpress.com>
@Aym3nTN Aym3nTN mentioned this pull request Oct 5, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@rishabh625 rishabh625 Awaiting requested review from rishabh625

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to filter MRs by 'state' to Gitlab PR Generator
2 participants
@Aym3nTN @crenshaw-dev