Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groups logging too verbose #9549

Closed
tooptoop4 opened this issue Jun 1, 2022 · 4 comments · Fixed by #9947
Closed

groups logging too verbose #9549

tooptoop4 opened this issue Jun 1, 2022 · 4 comments · Fixed by #9947
Labels
enhancement New feature or request

Comments

@tooptoop4
Copy link

i get logs like this every 15 seconds but the list of groups is 6000 characters long so the log storage becomes expensive

time="2022-06-01T05:52:39Z" level=info msg="received unary call /application.ApplicationService/List" grpc.method=List grpc.request.claims="{\"at_           hash\":\"redact\",\"aud\":\"argo-cd\",\"c_hash\":\"redact\",\"email\":\"redact\",\"email_ver           ified\":true,\"exp\":1654144159,\"groups\":[\"AC......really long list here....

argo-cd/util/grpc/logging.go

Line 20 in b37eee1

entry = entry.WithField("grpc.request.claims", string(data))

@tooptoop4 tooptoop4 added the enhancement New feature or request label Jun 1, 2022
@crenshaw-dev
Copy link
Collaborator

@tooptoop4 would you be up for a PR wrapping that with a debug log level check?

tooptoop4 added a commit to tooptoop4/argo-cd that referenced this issue Jul 2, 2022
@tooptoop4
fix: reduce log level for grpc claims
a2a6c6c 
fixes argoproj#9549
@tooptoop4 tooptoop4 mentioned this issue Jul 2, 2022
Closed
10 tasks
@tooptoop4
Copy link
Author

@crenshaw-dev #9862

crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this issue Jul 11, 2022
@crenshaw-dev
fix: don't log group claims unless log level is debug (argoproj#9549)
4e511eb 
Signed-off-by: CI <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev mentioned this issue Jul 11, 2022
Merged
crenshaw-dev added a commit that referenced this issue Jul 13, 2022
@crenshaw-dev
fix: don't log group claims unless log level is debug (#9549) (#9947)
665d83e 
* fix: don't log group claims unless log level is debug (#9549)

Signed-off-by: CI <michael@crenshaw.dev>

* ignore lint error

Signed-off-by: CI <michael@crenshaw.dev>
@crenshaw-dev
Copy link
Collaborator

@tooptoop4 lmk if you need this cherry-picked. #9947

Otherwise I'll just leave it for 2.5.

@tooptoop4
Copy link
Author

yes pls @crenshaw-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@crenshaw-dev @tooptoop4