env does not pass to configManagementPlugins in Argo CD v2.4.0

[czchen]

Checklist:

• I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• I've included steps to reproduce the bug.
• I've pasted the output of argocd version.

Describe the bug

When trying to upgrade from Argo v2.3.4 to v2.4.0, we found that plugin command cannot read ENV set in Application. The following is reproduce step:

To Reproduce

• Setup an application with the following configuration:

  apiVersion: argoproj.io/v1alpha1
  kind: Application
  spec:
    source:
      plugin:
        name: my-plugin
        env:
        - name: MY_ENV_NAME
          value: my-env-value

• Setup configManagementPlugin with the following configuration:

  configManagementPlugins:
    generate:
      command: ['sh', '-c']
      args: ['my-command "$MY_ENV_NAME"']

  • In my-command, print the first argument.

• The output of my-command is empty string instead of my-env-value.

Expected behavior

• Environment variable $MY_ENV_NAME shall be set to its value my-env-value defined in Application.

Screenshots

Version

argocd: v2.4.0+91aefab
  BuildDate: 2022-06-10T17:44:14Z
  GitCommit: 91aefabc5b213a258ddcfe04b8e69bb4a2dd2566
  GitTreeState: clean
  GoVersion: go1.18.3
  Compiler: gc
  Platform: linux/amd64
argocd-server: v2.4.0+91aefab

Logs

[czchen]

Find help in slack, https://argo-cd.readthedocs.io/en/latest/operator-manual/upgrading/2.3-2.4/#update-plugins-to-use-newly-prefixed-environment-variables