-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applicationset not refreshed after webhook event using matrix generator when using matrix generator references #9931
Comments
Are there any interesting logs in the applicationset controller when it handles the webhook event? |
No logs at all @crenshaw-dev -- just appears to be skipped altogether Here's a recent example of when I removed a label. Github webhook delivery looks to be returning a 200 so I know the webhook was received:
And in the application set controller logs I see that the application does eventually remove the application but via polling not webhook.
|
The webhook code just uses the string as defined in the appset, it does not do any interpolating/transforming/merging/templating as added in #9080. It is however unclear to me how to get the interpolated generator params from the impl of #9080. The Transform method seems to return rendered Application objects. |
Any thoughts on how this could be moved forward @crenshaw-dev? |
By chance I did have time last week to have a better look at it and was able to make a fix. |
#10236) * chore(applicationset): move webhook code to its own package Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com> * fix(applicationset): support matrix interpolation in webhook events Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com> Signed-off-by: Sverre Boschman <1142569+sboschman@users.noreply.github.com>
Much appreciated @sboschman!!! |
@KojoRising @crenshaw-dev @sboschman
Checklist:
argocd version
.Describe the bug
It appears that the changes from #8998 are not compatible with the work done in #9080. This has been confirmed by the author of #8998
To Reproduce
For example if I create an application set like this and setup a webhook for pull requests they will not be refreshed when pull request events happen.
Expected behavior
However if I do not attempt to use
{{organization}}
and{{repository}}
in the pull request generator then everything works as expected:I suspect there may be an issue with using the interpolated values that is causing the webhook event to be discarded.
The text was updated successfully, but these errors were encountered: