Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't log group claims unless log level is debug (#9549) #9947

Merged
merged 2 commits into from Jul 13, 2022
Merged

fix: don't log group claims unless log level is debug (#9549) #9947

merged 2 commits into from Jul 13, 2022

Conversation

crenshaw-dev
Copy link
Collaborator

@crenshaw-dev crenshaw-dev commented Jul 11, 2022 •
edited

Supersedes #9862

Fixes #9549

@crenshaw-dev crenshaw-dev mentioned this pull request Jul 11, 2022
Closed
10 tasks
@codecov
Copy link

codecov bot commented Jul 11, 2022 •
edited

Codecov Report

Merging #9947 (f2d7090) into master (179d1e0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #9947      +/-   ##
==========================================
+ Coverage   45.84%   45.86%   +0.02%     
==========================================
  Files         227      227              
  Lines       27095    27101       +6     
==========================================
+ Hits        12422    12431       +9     
+ Misses      12974    12972       -2     
+ Partials     1699     1698       -1
Impacted Files Coverage Δ
util/grpc/logging.go 58.33% <100.00%> (+18.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179d1e0...f2d7090. Read the comment docs.

@crenshaw-dev
ignore lint error
f2d7090 
Signed-off-by: CI <michael@crenshaw.dev>
alexmt
alexmt approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

notfromstatefarm
notfromstatefarm approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@notfromstatefarm notfromstatefarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

jannfis
jannfis approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev merged commit 665d83e into argoproj:master Jul 13, 2022
@crenshaw-dev crenshaw-dev deleted the do-not-log-group-claims branch July 13, 2022 15:22
@crenshaw-dev crenshaw-dev mentioned this pull request Jul 13, 2022
Closed
@notfromstatefarm notfromstatefarm mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

@jannfis jannfis jannfis approved these changes

@notfromstatefarm notfromstatefarm notfromstatefarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groups logging too verbose
4 participants
@crenshaw-dev @alexmt @jannfis @notfromstatefarm