Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codegen to sync manifest image tags with Procfile image tags #9955

Closed
crenshaw-dev opened this issue Jul 12, 2022 · 0 comments · Fixed by #9959
Closed

Add codegen to sync manifest image tags with Procfile image tags #9955

crenshaw-dev opened this issue Jul 12, 2022 · 0 comments · Fixed by #9959
Labels
enhancement New feature or request security Security related

Comments

@crenshaw-dev
Copy link
Collaborator

Summary

We need to automatically reflect changes to the redix/dex/haproxy image tags from the manifests directory to the Procfile so e2e tests use the correct version.

Motivation

e2e tests use the processes initiated in Procfile. We should use the same version in Procfile as what is set in the manifests.

Proposal

Probably a BASH script invoked from the Makefile. It should be part of the codegen target so that sync issues are caught in CI.
@crenshaw-dev crenshaw-dev added enhancement New feature or request security Security related labels Jul 12, 2022
notfromstatefarm added a commit to notfromstatefarm/argo-cd that referenced this issue Jul 12, 2022
@notfromstatefarm
chore: use manifest version for redis+dex in E2E tests (argoproj#9955)
82f8f5c 
Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
@notfromstatefarm notfromstatefarm mentioned this issue Jul 12, 2022
Merged
5 tasks
alexmt pushed a commit that referenced this issue Jul 13, 2022
@notfromstatefarm
chore: use manifest version for redis+dex in E2E tests (#9955) (#9959)
79178ea 
* chore: use manifest version for redis+dex in E2E tests (#9955)

Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>

* use grep and cut instead of yq

Signed-off-by: notfromstatefarm <86763948+notfromstatefarm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request security Security related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use manifest version for redis+dex in E2E tests (#9955) notfromstatefarm/argo-cd
1 participant
@crenshaw-dev