Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOB-ARGO-TM8: Set a reasonable default if UserSessionDuration parsing fails #9962

Closed
crenshaw-dev opened this issue Jul 12, 2022 · 4 comments · Fixed by #10185
Closed

TOB-ARGO-TM8: Set a reasonable default if UserSessionDuration parsing fails #9962

crenshaw-dev opened this issue Jul 12, 2022 · 4 comments · Fixed by #10185
Assignees
@numacci21
Labels
enhancement New feature or request good first issue Good for newcomers GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day

Comments

@crenshaw-dev
Copy link
Collaborator

Summary

When UserSessionDuration is parsed from argocd-cm, failed parsing defaults to 0. Instead, set a reasonable default.

argo-cd/util/settings/settings.go

Line 1274 in fdceed6

log.Warnf("Failed to parse '%s' key: %v", userSessionDurationKey, err)

@crenshaw-dev crenshaw-dev added enhancement New feature or request good first issue Good for newcomers GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day labels Jul 12, 2022
@crenshaw-dev crenshaw-dev changed the title Set a reasonable default if UserSessionDuration parsing fails TOB-ARGO-TM8: Set a reasonable default if UserSessionDuration parsing fails Jul 15, 2022
@deepto98
Copy link

Can I pick this up?

@numacci21
Copy link
Contributor

Hi @deepto98 , are you still working on this issue? If you don't have enough time to work on it, I can do it.

@numacci21
Copy link
Contributor

Hello @crenshaw-dev, the work on this Issue seems to be on hold. Is it possible for me to take over and work on it?

@crenshaw-dev crenshaw-dev assigned numacci21 and unassigned deepto98 Aug 1, 2022
@crenshaw-dev
Copy link
Collaborator Author

Thanks @y-takuya!

@numacci21 numacci21 mentioned this issue Aug 3, 2022
Merged
10 tasks
crenshaw-dev added a commit that referenced this issue Aug 5, 2022
@numacci21 @crenshaw-dev
fix: set default value for users.session.duration (#9962) (#10185)
7488f68 
* fix: set default value for users.session.duration

Signed-off-by: Takuya Yaginuma <biz.mkgoat.yagi+github@gmail.com>
Signed-off-by: y-takuya <biz.mkgoat.yagi+github@gmail.com>

* docs: add user.session.duration change

Signed-off-by: y-takuya <biz.mkgoat.yagi+github@gmail.com>

* docs: fix users.session.duration parameter name

Signed-off-by: y-takuya <biz.mkgoat.yagi+github@gmail.com>

* Retrigger CI pipeline

Signed-off-by: y-takuya <biz.mkgoat.yagi+github@gmail.com>

Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Aug 11, 2022
@numacci21 @crenshaw-dev
fix: set default value for users.session.duration (argoproj#9962) (ar…
a0634e6 
…goproj#10185)

* fix: set default value for users.session.duration

Signed-off-by: Takuya Yaginuma <biz.mkgoat.yagi+github@gmail.com>
Signed-off-by: y-takuya <biz.mkgoat.yagi+github@gmail.com>

* docs: add user.session.duration change

Signed-off-by: y-takuya <biz.mkgoat.yagi+github@gmail.com>

* docs: fix users.session.duration parameter name

Signed-off-by: y-takuya <biz.mkgoat.yagi+github@gmail.com>

* Retrigger CI pipeline

Signed-off-by: y-takuya <biz.mkgoat.yagi+github@gmail.com>

Co-authored-by: Michael Crenshaw <michael@crenshaw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@numacci21 numacci21

Labels
enhancement New feature or request good first issue Good for newcomers GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day
Projects
Ada Logics audit follow-up
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set default value for users.session.duration (#9962) numacci21/argo-cd
3 participants
@crenshaw-dev @deepto98 @numacci21