Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArgoCD Server Log Level env var incorrect #9970

Closed
sidewinder12s opened this issue Jul 13, 2022 · 0 comments · Fixed by #9975
Closed

ArgoCD Server Log Level env var incorrect #9970

sidewinder12s opened this issue Jul 13, 2022 · 0 comments · Fixed by #9975
Labels
bug Something isn't working good first issue Good for newcomers GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day

Comments

@sidewinder12s
Copy link

sidewinder12s commented Jul 13, 2022 •
edited

Shouldn't this environment variable and then Kustomize manifest env var be ARGOCD_SERVER_LOG_LEVEL?

Especially with config moving into the shared configmap?

argo-cd/manifests/base/server/argocd-server-deployment.yaml

Line 49 in 356307e

- name: ARGOCD_REPO_SERVER_LOGLEVEL

argo-cd/cmd/argocd-server/commands/argocd_server.go

Line 192 in ae19965

command.Flags().StringVar(&cmdutil.LogLevel, "loglevel", env.StringFromEnv("ARGOCD_REPO_SERVER_LOGLEVEL", "info"), "Set the logging level. One of: debug|info|warn|error")

argo-cd/manifests/namespace-install.yaml

Line 1159 in 179d1e0

- name: ARGOCD_REPO_SERVER_LOGLEVEL

argo-cd/manifests/ha/namespace-install.yaml

Line 1821 in 179d1e0

- name: ARGOCD_REPO_SERVER_LOGLEVEL

Version

2.3.5/master

Noticed this while debugging: #9695
@sidewinder12s sidewinder12s added the bug Something isn't working label Jul 13, 2022
@todaywasawesome todaywasawesome added the good first issue Good for newcomers label Jul 13, 2022
@crenshaw-dev crenshaw-dev added the GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day label Jul 13, 2022
@usernameisnull usernameisnull mentioned this issue Jul 13, 2022
Merged
10 tasks
crenshaw-dev pushed a commit that referenced this issue Jul 14, 2022
@usernameisnull
fix: api server should use ARGOCD_SERVER_LOG_LEVEL instead of ARGOCD_…
7d31d61 
…REPO_SERVER_LOGLEVEL (#9970) (#9975)

* change ARGOCD_REPO_SERVER_LOGLEVEL to ARGOCD_SERVER_LOG_LEVEL

Signed-off-by: mabing <bing.ma@daocloud.io>

* Changed too much,revert it.

Signed-off-by: mabing <bing.ma@daocloud.io>

* make manifests

Signed-off-by: mabing <bing.ma@daocloud.io>

Co-authored-by: mabing <bing.ma@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers GraceHopperOSD2022 Good for 2022 Grace Hopper Celebration Open Source Day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: api server should use ARGOCD_SERVER_LOG_LEVEL instead of ARGOCD_REPO_SERVER_LOGLEVEL (#9970)
3 participants
@crenshaw-dev @sidewinder12s @todaywasawesome