Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: argocd app create output states whether app exists #9984

Merged
merged 6 commits into from Jul 20, 2022

Conversation

danielhelfand
Copy link
Contributor

Closes #9969

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #9984 (21726e3) into master (99a889c) will decrease coverage by 0.06%.
The diff coverage is 51.85%.

@@            Coverage Diff             @@
##           master    #9984      +/-   ##
==========================================
- Coverage   45.96%   45.89%   -0.07%     
==========================================
  Files         227      227              
  Lines       27276    27353      +77     
==========================================
+ Hits        12538    12555      +17     
- Misses      13036    13095      +59     
- Partials     1702     1703       +1     
Impacted Files Coverage Δ
server/application/application.go 31.46% <ø> (ø)
cmd/argocd/commands/app.go 20.62% <51.85%> (+0.62%) ⬆️
util/grpc/useragent.go 45.83% <0.00%> (-10.42%) ⬇️
server/rbacpolicy/rbacpolicy.go 82.35% <0.00%> (-2.43%) ⬇️
server/application/websocket.go 7.54% <0.00%> (-0.46%) ⬇️
pkg/apiclient/grpcproxy.go 0.00% <0.00%> (ø)
...is/applicationset/v1alpha1/applicationset_types.go 34.69% <0.00%> (+2.55%) ⬆️
server/logout/logout.go 84.37% <0.00%> (+6.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a889c...21726e3. Read the comment docs.

server/application/application.go Outdated Show resolved Hide resolved
@crenshaw-dev
Copy link
Collaborator

Merging master will fix the readthedocs failure.

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks @danielhelfand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOB-ARGO-022: CLI suggests that it is possible to create the same application twice
2 participants