Set session cookies, errors appropriately #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand this improvement to security. If it's set in the cookie, it might as well be in the response. I think having consistent behavior is important if this doesn't improve security. |
|
@jessesuen on some further thought (as discussed in Slack, but here for the record), since login will likely be over JavaScript API, I've removed the HttpOnly flag, set |
jessesuen
approved these changes
Apr 19, 2018
leoluz
pushed a commit
to leoluz/argo-cd
that referenced
this pull request
Sep 29, 2023
1. Instead of global semaphore use a per-cache semaphore. Removes thread-safety issues, allows fine control over limiting if multiple caches are used in a program 2. Use the semaphore to guard whole sections that use expensive list operations, not just the list API call. This ensures that memory usage is capped, not the list operations. 3. Allow to control list pager. Reduce default prefetch limit to 1 page from 10. Co-authored-by: Alexander Matyushentsev <Alexander_Matyushentsev@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proper
Set-Cookieresponse header when returning cookies to HTTP clients.Fix 500 errors on invalid login (was my newbie error in returning non-gRPC errors from session service on invalid login). Now returning gRPC errors as needed.
Don't do anything with gRPC headers. Simply intercept all session service requests and set a cookie based on the token from any successful response, which is going to be either a login (
Create) or logout (Delete).4. Security improvement: Don't return token as text in response if client is HTTP: the HTTP client never gets to see the token now, except in the cookie (which, beingHttpOnly, cannot be accessed by JavaScript).Secureflag on cookie only when--insecureisfalse.