Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: argocd app manifests --local (#5525) #10061

Merged

Conversation

crenshaw-dev
Copy link
Collaborator

Fixes #5525

Supersedes #7658

Cylix and others added 3 commits February 12, 2022 17:34
Signed-off-by: Simon Ninon <simon.ninon@gmail.com>
Signed-off-by: CI <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #10061 (5b9197d) into master (2cff57e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #10061      +/-   ##
==========================================
- Coverage   45.89%   45.86%   -0.03%     
==========================================
  Files         227      227              
  Lines       27327    27344      +17     
==========================================
  Hits        12541    12541              
- Misses      13084    13101      +17     
  Partials     1702     1702              
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 19.75% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cff57e...5b9197d. Read the comment docs.

Signed-off-by: CI <michael@crenshaw.dev>
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@crenshaw-dev crenshaw-dev merged commit 9211034 into argoproj:master Jul 25, 2022
@crenshaw-dev crenshaw-dev deleted the 5525-cli-app-manifests-local branch July 25, 2022 18:01
@fabricepipart1a
Copy link

Hi!
We would be interested to use this feature (and were actually waiting for it). Do you have any forecast / idea when it cold be integrated in a future release?

@crenshaw-dev
Copy link
Collaborator Author

@fabricepipart1a it will be in 2.5, which should have an RC within the next two weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD CLI local template
4 participants