-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add projects filter to app sync command (merge fix) (#8320) #10133
feat: add projects filter to app sync command (merge fix) (#8320) #10133
Conversation
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com>
This PR addresses a merge conflict from #8343 I have tested this change locally. I'm still setting up the tooling but seems like an e2e test is in order as well. Should be able to free up some time this weekend to address that. |
Codecov Report
@@ Coverage Diff @@
## master #10133 +/- ##
==========================================
+ Coverage 45.88% 45.91% +0.02%
==========================================
Files 227 227
Lines 27373 27410 +37
==========================================
+ Hits 12560 12584 +24
- Misses 13109 13117 +8
- Partials 1704 1709 +5
Continue to review full report at Codecov.
|
Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com>
Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @justinwatkinson!
…oj#10133) * feat: add projects filter to app sync command Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com> * test: add e2e sync by project Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com> * Retrigger CI pipeline Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com> Co-authored-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Using the project filter we can sync apps that belong to a particular project
argocd app sync --project test --project dev
The above command would sync all apps in the projects test and dev
Closes: #8320