Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add projects filter to app sync command (merge fix) (#8320) #10133

Merged

Conversation

justinwatkinson
Copy link
Contributor

@justinwatkinson justinwatkinson commented Jul 29, 2022

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Using the project filter we can sync apps that belong to a particular project

argocd app sync --project test --project dev

The above command would sync all apps in the projects test and dev

Closes: #8320

chetan-rns and others added 2 commits April 1, 2022 18:09
Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com>
@justinwatkinson
Copy link
Contributor Author

This PR addresses a merge conflict from #8343

I have tested this change locally. I'm still setting up the tooling but seems like an e2e test is in order as well. Should be able to free up some time this weekend to address that.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #10133 (464b121) into master (e3940cd) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #10133      +/-   ##
==========================================
+ Coverage   45.88%   45.91%   +0.02%     
==========================================
  Files         227      227              
  Lines       27373    27410      +37     
==========================================
+ Hits        12560    12584      +24     
- Misses      13109    13117       +8     
- Partials     1704     1709       +5     
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 20.27% <0.00%> (-0.10%) ⬇️
util/db/gpgkeys.go 77.14% <0.00%> (-1.97%) ⬇️
util/gpg/gpg.go 66.96% <0.00%> (-1.25%) ⬇️
util/settings/settings.go 50.90% <0.00%> (ø)
pkg/apis/application/v1alpha1/app_project_types.go 59.61% <0.00%> (+5.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3940cd...464b121. Read the comment docs.

Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com>
Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com>
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crenshaw-dev crenshaw-dev merged commit 4e7434a into argoproj:master Aug 8, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 11, 2022
…oj#10133)

* feat: add projects filter to app sync command

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>

* test: add e2e sync by project

Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com>

* Retrigger CI pipeline

Signed-off-by: Justin Watkinson <justin.watkinson@gmail.com>

Co-authored-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add project Filter to argocd app sync sub-dommand
3 participants