Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade go version to v1.18 #10351

Merged
merged 1 commit into from Aug 16, 2022

Conversation

ishitasequeira
Copy link
Member

Signed-off-by: ishitasequeira ishiseq29@gmail.com

Reverting go version to 1.18 as go mod download fails in MacOS with go 1.19.
Slack discussion can be found here

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #10351 (ba8cebd) into master (9b4f468) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10351   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files         228      228           
  Lines       28004    28004           
=======================================
  Hits        12927    12927           
  Misses      13324    13324           
  Partials     1753     1753           
Impacted Files Coverage Δ
util/settings/settings.go 51.36% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) August 16, 2022 14:12
@crenshaw-dev crenshaw-dev merged commit 56be7b6 into argoproj:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants