Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix subscription health check #10450

Merged

Conversation

ishitasequeira
Copy link
Member

Signed-off-by: ishitasequeira ishiseq29@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@ishitasequeira ishitasequeira changed the title chore: fix subscription health check fix: fix subscription health check Aug 25, 2022
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #10450 (f4a4afb) into master (a23bfc3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10450   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files         233      233           
  Lines       28401    28401           
=======================================
  Hits        12998    12998           
  Misses      13629    13629           
  Partials     1774     1774           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ishitasequeira ishitasequeira marked this pull request as ready for review August 25, 2022 16:21
Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ishitasequeira!

@jannfis jannfis merged commit 40594cd into argoproj:master Aug 29, 2022
ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this pull request Aug 30, 2022
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@sathieu
Copy link
Contributor

sathieu commented Sep 7, 2022

@ashutosh16 Shouldn't InstallPlanMissing lead to progressing?

@ishitasequeira ishitasequeira added the cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch label Sep 26, 2022
crenshaw-dev pushed a commit that referenced this pull request Sep 30, 2022
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>

Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
@crenshaw-dev
Copy link
Collaborator

Cherry-picked onto release-2.4 for 2.4.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/2.4 Candidate for cherry picking into the 2.4 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants