Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable metadata to be set on namespaces #10672

Merged
merged 12 commits into from
Nov 4, 2022
Merged

feat: enable metadata to be set on namespaces #10672

merged 12 commits into from
Nov 4, 2022

Commits on Nov 4, 2022

  1. namespace labels 

    Signed-off-by: pashavictorovich <pavel@codefresh.io>
    @pasha-codefresh @blakepettersson
    pasha-codefresh authored and blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    d33d23a View commit details
    Browse the repository at this point in the history

  2. create namespace should support annotations 

    Signed-off-by: pashavictorovich <pavel@codefresh.io>
    @pasha-codefresh @blakepettersson
    pasha-codefresh authored and blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    dc6969f View commit details
    Browse the repository at this point in the history

  3. handle also modification hook 

    Signed-off-by: pashavictorovich <pavel@codefresh.io>
    @pasha-codefresh @blakepettersson
    pasha-codefresh authored and blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e69c2df View commit details
    Browse the repository at this point in the history

  4. regenerate entity on modify hook 

    Signed-off-by: pashavictorovich <pavel@codefresh.io>
    @pasha-codefresh @blakepettersson
    pasha-codefresh authored and blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    14e1877 View commit details
    Browse the repository at this point in the history

  5. manifests 

    Signed-off-by: pashavictorovich <pavel@codefresh.io>
    @pasha-codefresh @blakepettersson
    pasha-codefresh authored and blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e01eb88 View commit details
    Browse the repository at this point in the history

  6. feat: enable metadata to be set on namespaces 

    This builds upon the work that @pasha-codefresh did in argoproj#10288.

The main differences between this PR and the previous one is that we use
SSA to diff between different versions of the namespace, as well as
having a slightly different API in gitops-engine for setting the
namespace modifier.

We now also set the ownership of the namespace in ArgoCD.

Closes argoproj#4628
Closes argoproj#6215
Closes argoproj#7799

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
    @blakepettersson
    blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    4426079 View commit details
    Browse the repository at this point in the history

  7. fix: don't always track namespaces 

    For now, only allow namespaces managed with `managedNamespaceMetadata`
to have tracking set by Argo. Ideally we'd like new namespaces to also
be tracked by Argo, but there's currently an issue with a failing
integration test.

Also wrap error message if setting the app instance errors on the
namespace.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
    @blakepettersson
    blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7cb2a9f View commit details
    Browse the repository at this point in the history

  8. fix: always return true with hasManagedMetadata 

    If `hasManagedMetadata` is set, `true` should always be returned.

Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
    @blakepettersson
    blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e774851 View commit details
    Browse the repository at this point in the history

  9. docs: add clarifying docs on resource tracking 

    Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
    @blakepettersson
    blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    cdd8897 View commit details
    Browse the repository at this point in the history

  10. style: pr tweaks 

    Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
    @blakepettersson
    blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    33f1b0d View commit details
    Browse the repository at this point in the history

  11. fix: re-add label unsetting 

    Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
    @blakepettersson
    blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    3f992f1 View commit details
    Browse the repository at this point in the history

  12. Update gitops-engine to current master 

    Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
    @leoluz @blakepettersson
    leoluz authored and blakepettersson committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    d76f316 View commit details
    Browse the repository at this point in the history