-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: equality-based and set-based filtering by label keys and values for list, sync, delete and wait App commands (#10548) #10729
Conversation
Codecov ReportBase: 45.65% // Head: 45.68% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10729 +/- ##
==========================================
+ Coverage 45.65% 45.68% +0.02%
==========================================
Files 236 236
Lines 28702 28706 +4
==========================================
+ Hits 13104 13113 +9
+ Misses 13804 13800 -4
+ Partials 1794 1793 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
841bb08
to
5ea1d94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, @maheshbaliga!
Could you add examples to each of the commands' Example
text?
Also, would you have time to implement the same improvement for the argocd app delete
command? I just merged -l
support for that command.
5ea1d94
to
362d2dc
Compare
… for list, sync, delete and wait App commands. Signed-off-by: maheshbaliga <mahesh.baliga@infracloud.io>
362d2dc
to
5d835dd
Compare
@crenshaw-dev, thank you for the review. The examples have been added for List, Sync, Delete & Wait commands. Also, I pulled the label selector changes made to the Delete command and tested it with my code changes. This filtering logic works with Delete command too, since this flow also invokes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maheshbaliga!
This PR resolves the
-l / --selector flag
part of the issue #10548 , where apps can be filtered with theirs labels and values. It achieves feature-parity with kubectl.List, Sync, Delete and Wait commands to manage applications can now be filtered by label keys and values. Matching apps must satisfy all of the specified label constraints, though they may have additional labels as well. Equality-based operators allowed are =, == and !=. Set-based operators allowed are exists, not exists, in & notin.
Checklist: