Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide app namespace when irrelevant (#11111) #11165

Closed
wants to merge 2 commits into from

Conversation

crenshaw-dev
Copy link
Collaborator

Fixes #11111

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 45.60% // Head: 45.61% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (465efab) compared to base (f60ae50).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11165      +/-   ##
==========================================
+ Coverage   45.60%   45.61%   +0.01%     
==========================================
  Files         237      237              
  Lines       28914    28926      +12     
==========================================
+ Hits        13185    13195      +10     
- Misses      13913    13914       +1     
- Partials     1816     1817       +1     
Impacted Files Coverage Δ
util/settings/settings.go 51.25% <ø> (ø)
server/server.go 52.99% <100.00%> (+0.07%) ⬆️
applicationset/utils/utils.go 80.35% <0.00%> (-0.63%) ⬇️
util/argo/resource_tracking.go 70.45% <0.00%> (+0.33%) ⬆️
controller/state.go 72.93% <0.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexef alexef mentioned this pull request Nov 9, 2022
10 tasks
@crenshaw-dev
Copy link
Collaborator Author

Superseded by #11247

@crenshaw-dev crenshaw-dev deleted the hide-app-namespace branch November 18, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable argo-cd namespace in applications title on web-ui
1 participant