Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trash icon for resources to be pruned, plus better tooltip (#10290) #11171

Conversation

schakrad
Copy link
Contributor

@schakrad schakrad commented Nov 2, 2022

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [x ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Screen Shot 2022-11-02 at 4 31 53 PM

Trashcan is used for showing that the resource is out of sync and the resource will be deleted when we enable prune on sync.

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>
Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>
@schakrad schakrad changed the title #10290 trash icon for to be pruned resource fix #10290 trash icon for the resource that gets pruned on sync, when enabled prune on sync. Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 47.29% // Head: 47.29% // No change to project coverage 👍

Coverage data is based on head (104d544) compared to base (e82a644).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11171   +/-   ##
=======================================
  Coverage   47.29%   47.29%           
=======================================
  Files         245      245           
  Lines       41670    41670           
=======================================
  Hits        19707    19707           
  Misses      19978    19978           
  Partials     1985     1985           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

schakrad and others added 2 commits November 7, 2022 23:57
Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev changed the title #10290 trash icon for the resource that gets pruned on sync, when enabled prune on sync. fix(ui): trash icon for the resource that gets pruned on sync, when enabled prune on sync (#10290) Jan 12, 2023
@crenshaw-dev crenshaw-dev changed the title fix(ui): trash icon for the resource that gets pruned on sync, when enabled prune on sync (#10290) fix(ui): trash icon for resources to be pruned, plus better tooltip (#10290) Jan 12, 2023
@crenshaw-dev crenshaw-dev merged commit 63e410a into argoproj:master Jan 12, 2023
emirot pushed a commit to emirot/argo-cd that referenced this pull request Jan 27, 2023
…rgoproj#10290) (argoproj#11171)

* Trash Icon for the resource that will be pruned on sync

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>

* Trash icon for the resource that gets pruned on sync.

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>

* Tobepruned icon on grid view

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>

* Update ui/src/app/applications/components/utils.tsx

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
@schakrad schakrad changed the title fix(ui): trash icon for resources to be pruned, plus better tooltip (#10290) fix: trash icon for resources to be pruned, plus better tooltip (#10290) Jan 31, 2023
schakrad added a commit to schakrad/argo-cd that referenced this pull request Mar 14, 2023
…rgoproj#10290) (argoproj#11171)

* Trash Icon for the resource that will be pruned on sync

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>

* Trash icon for the resource that gets pruned on sync.

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>

* Tobepruned icon on grid view

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>

* Update ui/src/app/applications/components/utils.tsx

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants