-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trash icon for resources to be pruned, plus better tooltip (#10290) #11171
Merged
crenshaw-dev
merged 5 commits into
argoproj:master
from
schakrad:#10290-trash-icon-for-toBePrunedResource--fix
Jan 12, 2023
Merged
fix: trash icon for resources to be pruned, plus better tooltip (#10290) #11171
crenshaw-dev
merged 5 commits into
argoproj:master
from
schakrad:#10290-trash-icon-for-toBePrunedResource--fix
Jan 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>
Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>
schakrad
changed the title
#10290 trash icon for to be pruned resource fix
#10290 trash icon for the resource that gets pruned on sync, when enabled prune on sync.
Nov 2, 2022
Codecov ReportBase: 47.29% // Head: 47.29% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #11171 +/- ##
=======================================
Coverage 47.29% 47.29%
=======================================
Files 245 245
Lines 41670 41670
=======================================
Hits 19707 19707
Misses 19978 19978
Partials 1985 1985 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
crenshaw-dev
reviewed
Nov 4, 2022
Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com>
crenshaw-dev
requested changes
Jan 12, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
changed the title
#10290 trash icon for the resource that gets pruned on sync, when enabled prune on sync.
fix(ui): trash icon for the resource that gets pruned on sync, when enabled prune on sync (#10290)
Jan 12, 2023
crenshaw-dev
changed the title
fix(ui): trash icon for the resource that gets pruned on sync, when enabled prune on sync (#10290)
fix(ui): trash icon for resources to be pruned, plus better tooltip (#10290)
Jan 12, 2023
crenshaw-dev
approved these changes
Jan 12, 2023
emirot
pushed a commit
to emirot/argo-cd
that referenced
this pull request
Jan 27, 2023
…rgoproj#10290) (argoproj#11171) * Trash Icon for the resource that will be pruned on sync Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com> * Trash icon for the resource that gets pruned on sync. Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com> * Tobepruned icon on grid view Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com> * Update ui/src/app/applications/components/utils.tsx Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: emirot <emirot.nolan@gmail.com>
schakrad
changed the title
fix(ui): trash icon for resources to be pruned, plus better tooltip (#10290)
fix: trash icon for resources to be pruned, plus better tooltip (#10290)
Jan 31, 2023
schakrad
added a commit
to schakrad/argo-cd
that referenced
this pull request
Mar 14, 2023
…rgoproj#10290) (argoproj#11171) * Trash Icon for the resource that will be pruned on sync Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com> * Trash icon for the resource that gets pruned on sync. Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com> * Tobepruned icon on grid view Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com> * Update ui/src/app/applications/components/utils.tsx Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakradari <58915923+schakrad@users.noreply.github.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: schakrad <chakradari.sindhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Trashcan is used for showing that the resource is out of sync and the resource will be deleted when we enable prune on sync.