Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vulnerabilities in dependency package hints #11434

Closed
wants to merge 2 commits into from

Conversation

fengshunli
Copy link
Member

@fengshunli fengshunli commented Nov 25, 2022

Signed-off-by: fengshunli fengshunli520@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@fengshunli
Copy link
Member Author

upgrade package dependencies
image
show after repair
image
@crenshaw-dev @alexef can be merged

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 46.70% // Head: 46.70% // No change to project coverage 👍

Coverage data is based on head (ab7e214) compared to base (752bc5f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11434   +/-   ##
=======================================
  Coverage   46.70%   46.70%           
=======================================
  Files         240      240           
  Lines       39771    39771           
=======================================
  Hits        18577    18577           
  Misses      19310    19310           
  Partials     1884     1884           
Impacted Files Coverage Δ
util/settings/settings.go 48.87% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: fsl <1171313930@qq.com>
@crenshaw-dev
Copy link
Collaborator

@fengshunli can we split this into multiple PRs? I'd like to cherry-pick back the x/net upgrade but leave the others for 2.6 to minimize potentially introducing bugs.

@fengshunli
Copy link
Member Author

@fengshunli can we split this into multiple PRs? I'd like to cherry-pick back the x/net upgrade but leave the others for 2.6 to minimize potentially introducing bugs.

goutils and mongo-driver @crenshaw-dev there are potential security risks, which need to be upgraded to solve

@crenshaw-dev
Copy link
Collaborator

@fengshunli those can be in a separate PR. They'll need more analysis, because we may or may not want to cherry-pick them back, depending on the risk/benefit of closing the vulnerability vs. introducing bugs on patch releases.

@fengshunli
Copy link
Member Author

fengshunli commented Nov 27, 2022

@crenshaw-dev do you mean, I separate indirect dependencies and direct references to pr? see net pr #11447

@blakepettersson
Copy link
Member

Closing since none of these deps apply anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants