Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: valid username in webhook URL matching regex #12203

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix: valid username in webhook URL matching regex #12203

merged 1 commit into from
Feb 17, 2023

Commits on Feb 2, 2023

  1. fix: valid username in webhook URL matching regex 

    This commit fixes incorrect regular expression used for URL matching.

Expected behavior: valid user info part is matched => webhook is sent.
Actual behavior: some valid user info is not matched, example: `ssh://user-name@example.com/org/repo` => webhook is not sent.

Context:
 - [RFC 3986 3.2.1 - User Information](https://www.rfc-editor.org/rfc/rfc3986#section-3.2.1)
 - [Username validation regex in shadow Linux package](https://github.com/shadow-maint/shadow/blob/master/libmisc/chkname.c#L36)
Signed-off-by: mdsjip <2284562+mdsjip@users.noreply.github.com>
    @mdsjip
    mdsjip committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    2b9dc24 View commit details
    Browse the repository at this point in the history