fix: log plugin commands in a better format #12260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #12260 +/- ##
==========================================
+ Coverage 47.77% 47.79% +0.01%
==========================================
Files 246 246
Lines 42060 42075 +15
==========================================
+ Hits 20096 20111 +15
Misses 19962 19962
Partials 2002 2002
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
drpaneas
approved these changes
Feb 21, 2023
|
/cherry-pick release-2.6 |
jannfis
reviewed
Feb 24, 2023
jannfis
reviewed
Feb 24, 2023
|
/cherry-pick release-2.5 |
|
/cherry-pick release-2.4 |
|
@jannfis made requested changes, PTAL |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2023
* fix: log plugin commands in a better format Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * comments Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-pick failed with |
|
Cherry-pick failed with |
crenshaw-dev
added a commit
that referenced
this pull request
Mar 15, 2023
* fix: log plugin commands in a better format Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * comments Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Mar 15, 2023
* fix: log plugin commands in a better format Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * comments Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Cherry-picked onto release-2.5 for 2.5.15 and release-2.4 for 2.4.27. |
crenshaw-dev
added a commit
that referenced
this pull request
Mar 15, 2023
alexec
pushed a commit
to alexec/argo-cd
that referenced
this pull request
Mar 19, 2023
* fix: log plugin commands in a better format Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * comments Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* fix: log plugin commands in a better format Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * comments Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin logs are misleading.
sh -c echo hello worldmakes no sense. Log assh -c "echo hello world"instead.