Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appset): add notLabels to applicationset pullrequest generator (#12300) #12336

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mnacharov
Copy link

@mnacharov mnacharov commented Feb 8, 2023

Begins work on #12300

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

…#12300)

Signed-off-by: Mikhail Nacharov <mike.nacharov@gmail.com>
Signed-off-by: Mikhail Nacharov <mike.nacharov@gmail.com>
@crenshaw-dev crenshaw-dev changed the title feat: add notLabels to applicationset pullrequest generator (#12300) feat(appset): add notLabels to applicationset pullrequest generator (#12300) Mar 29, 2023
@crenshaw-dev
Copy link
Collaborator

@mnacharov do you have time to implement this as matchExpressions instead of notLabels?

@mnacharov
Copy link
Author

I'll try to find time this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants