Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer dereference in CompareAppState #1234

Merged

Conversation

jessesuen
Copy link
Member

Resolves #1233

@codecov-io
Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #1234 into release-0.12 will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-0.12    #1234     +/-   ##
===============================================
+ Coverage          37.3%   37.41%   +0.1%     
===============================================
  Files                59       59             
  Lines              8835     8836      +1     
===============================================
+ Hits               3296     3306     +10     
+ Misses             5039     5026     -13     
- Partials            500      504      +4
Impacted Files Coverage Δ
controller/state.go 75% <100%> (+0.13%) ⬆️
controller/appcontroller.go 32.77% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36dc50c...23810bc. Read the comment docs.

@alexmt alexmt merged commit 2f0dc20 into argoproj:release-0.12 Mar 6, 2019
alexmt pushed a commit to alexmt/argo-cd that referenced this pull request Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants