Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make webhook handler work for all configured application namespaces (#11867) #12386

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: make webhook handler work for all configured application namespaces (#11867) #12386

merged 1 commit into from
Mar 24, 2023

Conversation

SJrX
Copy link
Contributor

@SJrX SJrX commented Feb 9, 2023 •
edited

Fixes #11867
Signed-off-by: Steve Ramage commits@sjrx.net

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@SJrX SJrX force-pushed the issue-11867-fix-two branch 2 times, most recently from 484e4c8 to 5dfe6eb Compare February 9, 2023 22:31
@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.28 ⚠️

Comparison is base (5d53415) 48.92% compared to head (cb523b4) 47.64%.

❗ Current head cb523b4 differs from pull request most recent head 3adbc6d. Consider uploading reports for the commit 3adbc6d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12386      +/-   ##
==========================================
- Coverage   48.92%   47.64%   -1.28%     
==========================================
  Files         246      246              
  Lines       42360    41821     -539     
==========================================
- Hits        20724    19926     -798     
- Misses      19531    19902     +371     
+ Partials     2105     1993     -112
Impacted Files Coverage Δ
server/application/application.go 29.53% <100.00%> (-20.67%) ⬇️
server/server.go 56.65% <100.00%> (+1.08%) ⬆️
util/webhook/webhook.go 69.65% <100.00%> (+1.27%) ⬆️

... and 44 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SJrX SJrX force-pushed the issue-11867-fix-two branch 2 times, most recently from 9d5311d to f4be8a5 Compare February 9, 2023 23:29
@SJrX SJrX marked this pull request as ready for review February 10, 2023 05:05
@SJrX SJrX marked this pull request as draft February 10, 2023 20:22
@SJrX SJrX force-pushed the issue-11867-fix-two branch 4 times, most recently from fe19b07 to f8f5863 Compare February 16, 2023 15:02
@SJrX SJrX force-pushed the issue-11867-fix-two branch 2 times, most recently from cfe22a8 to eed84aa Compare February 23, 2023 17:54
@SJrX SJrX marked this pull request as ready for review February 23, 2023 17:54
fix: make webhook handler work in all configured application namespac…
3adbc6d 
…es (argoproj#11867)

Signed-off-by: Steve Ramage <commits@sjrx.net>
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

@crenshaw-dev crenshaw-dev merged commit 06cd025 into argoproj:master Mar 24, 2023
@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 06cd0251196920a8a65a90ac1c1c6fc599a4bfa6 into temp-cherry-pick-0d97a5-release-2.5

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 06cd0251196920a8a65a90ac1c1c6fc599a4bfa6 into temp-cherry-pick-0d97a5-release-2.6

crenshaw-dev pushed a commit that referenced this pull request Mar 24, 2023
@SJrX @crenshaw-dev
fix: make webhook handler work in all configured application namespac…
707342d 
…es (#11867) (#12386)

Signed-off-by: Steve Ramage <commits@sjrx.net>
Co-authored-by: Steve Ramage <commits@sjrx.net>
crenshaw-dev pushed a commit that referenced this pull request Mar 24, 2023
@SJrX @crenshaw-dev
fix: make webhook handler work in all configured application namespac…
ee174fa 
…es (#11867) (#12386)

Signed-off-by: Steve Ramage <commits@sjrx.net>
Co-authored-by: Steve Ramage <commits@sjrx.net>
@crenshaw-dev
Copy link
Collaborator

Manually cherry-picked.

@rbreeze rbreeze mentioned this pull request Apr 13, 2023
Closed
3 tasks
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@SJrX
fix: make webhook handler work in all configured application namespac…
9d7f046 
…es (argoproj#11867) (argoproj#12386)

Signed-off-by: Steve Ramage <commits@sjrx.net>
Co-authored-by: Steve Ramage <commits@sjrx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

@jannfis jannfis Awaiting requested review from jannfis

Assignees
No one assigned
Labels
cherry-pick/2.5 cherry-pick/2.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webhook only refresh applications in argocd installation namespace
2 participants
@SJrX @crenshaw-dev