fix: Lint Go code(#12522) #12523
Merged
fix: Lint Go code(#12522) #12523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: juunini <juuni.ni.i@gmail.com>
Signed-off-by: juunini <juuni.ni.i@gmail.com>
Codecov ReportBase: 47.76% // Head: 47.77% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #12523 +/- ##
=======================================
Coverage 47.76% 47.77%
=======================================
Files 246 246
Lines 41910 41910
=======================================
+ Hits 20020 20023 +3
+ Misses 19891 19889 -2
+ Partials 1999 1998 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
34fathombelow
requested changes
Feb 18, 2023
| @@ -185,7 +185,7 @@ SyncPolicy: Automated | |||
| printAppSetSummaryTable(tt.appSet) | |||
| w.Close() | |||
|
|
|||
| out, err := ioutil.ReadAll(r) | |||
| out, err := io.ReadAll(r) | |||
There was a problem hiding this comment.
Suggested change
| out, err := io.ReadAll(r) | |
| out, err := os.ReadAll(r) |
There was a problem hiding this comment.
I was change io.ReadAll to os.ReadAll and remove import io.
But, os.ReadAll is not exists.
so, git reset and force push before commit
juunini
force-pushed
the
fix/go-lint-code
branch
from
0de07d8
to
32af28b
Compare
34fathombelow
approved these changes
Feb 18, 2023
crenshaw-dev
approved these changes
Feb 19, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* fix: `io/ioutil` to `io` Signed-off-by: juunini <juuni.ni.i@gmail.com> * docs: add cloudmate in users Signed-off-by: juunini <juuni.ni.i@gmail.com> --------- Signed-off-by: juunini <juuni.ni.i@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Description
[ISSUE #12522]
Change
io/utiltoio