Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url in doc link #12744

Merged
merged 2 commits into from Mar 7, 2023
Merged

fix: url in doc link #12744

merged 2 commits into from Mar 7, 2023

Conversation

iNoahNothing
Copy link
Contributor

Signed-off-by: Noah Krause krausenoah@gmail.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO

Signed-off-by: Noah Krause <krausenoah@gmail.com>
@iNoahNothing iNoahNothing changed the title fix: type in doc link fix: url in doc link Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (133ff29) 47.79% compared to head (eea2616) 47.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12744   +/-   ##
=======================================
  Coverage   47.79%   47.79%           
=======================================
  Files         246      246           
  Lines       41968    41968           
=======================================
  Hits        20058    20058           
  Misses      19910    19910           
  Partials     2000     2000           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iNoahNothing!

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.5

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) March 7, 2023 20:32
@crenshaw-dev crenshaw-dev merged commit 9fb7847 into argoproj:master Mar 7, 2023
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 7, 2023
Signed-off-by: Noah Krause <krausenoah@gmail.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Mar 7, 2023
Signed-off-by: Noah Krause <krausenoah@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Mar 7, 2023
Signed-off-by: Noah Krause <krausenoah@gmail.com>
Co-authored-by: Noah Krause <krausenoah@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Mar 7, 2023
Signed-off-by: Noah Krause <krausenoah@gmail.com>
Co-authored-by: Noah Krause <krausenoah@gmail.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Noah Krause <krausenoah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants