Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update RBAC example to include permissions for projects #12773

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Mar 8, 2023

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (b96bf6b) 49.06% compared to head (cbf65ad) 49.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12773      +/-   ##
==========================================
- Coverage   49.06%   49.06%   -0.01%     
==========================================
  Files         246      246              
  Lines       42587    42587              
==========================================
- Hits        20897    20894       -3     
- Misses      19574    19576       +2     
- Partials     2116     2117       +1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@morey-tech
Copy link
Contributor

@rodrigc can you clarify why project permissions should be added to the RBAC example? I'm personally in favour since an org-admin is likely to be responsible for Projects, but I'm wondering what your thoughts are.

@rodrigc
Copy link
Contributor Author

rodrigc commented Mar 22, 2023

@morey-tech see this Slack discussion thread:
https://cloud-native.slack.com/archives/C01TSERG0KZ/p1678307945559999

without this RBAC change, argo app get
would not work, even for a member of org-admin.

Specifically, in my argo setup, which is running argocd-server: v2.5.4+86b2dde , I can do this successfully:

but when I try to do a get on a specific app,

argocd app get argocd/apps

I get:

FATA[0001] rpc error: code = PermissionDenied desc = permission denied: projects, get, default, sub: ChUxMTQ3NTY4NjAwMjIzNzczNjIzNDISBmdvb2dsZQ, iat: 2023-03-08T16:57:17Z

I needed to modify the RBAC rules as per this patch to get things to work.
I thought it would be good to get this into the docs, since
I followed the docs when setting up argo.

Signed-off-by: Craig Rodrigues <craig@quiknode.io>
@crenshaw-dev crenshaw-dev merged commit 3ad4bf4 into argoproj:master Apr 18, 2023
@rodrigc rodrigc deleted the add-projects-to-rbac-cm branch April 21, 2023 15:01
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants