fix: Regression in signature verification for git tags #12797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jannfis <jann@mistrust.net>
3 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #12797 +/- ##
=========================================
Coverage ? 47.77%
=========================================
Files ? 246
Lines ? 41986
Branches ? 0
=========================================
Hits ? 20058
Misses ? 19929
Partials ? 1999
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-2.4 |
|
/cherry-pick release-2.5 |
|
/cherry-pick release-2.6 |
|
@crenshaw-dev bump :) |
|
/cherry-pick release-2.7 |
crenshaw-dev
approved these changes
Apr 4, 2023
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
Signed-off-by: jannfis <jann@mistrust.net>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
Signed-off-by: jannfis <jann@mistrust.net>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
Signed-off-by: jannfis <jann@mistrust.net>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
Signed-off-by: jannfis <jann@mistrust.net>
crenshaw-dev
pushed a commit
that referenced
this pull request
May 28, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
May 28, 2023
crenshaw-dev
pushed a commit
that referenced
this pull request
May 28, 2023
3 tasks
schakrad
pushed a commit
to schakrad/argo-cd
that referenced
this pull request
Jul 24, 2023
… (argoproj#13113) Signed-off-by: jannfis <jann@mistrust.net> Co-authored-by: jannfis <jann@mistrust.net> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
Signed-off-by: jannfis <jann@mistrust.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7377
There was a regression not covered by tests when we changed passing the resolved commit SHA (instead of the symbolic reference) to verification routines, which resulted in trying to run
git verify-tagon a commit SHA a tag was pointing to, instead of running against the tag.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: