Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes sharding placement algorithm and allows development of alternative algorithms #13018

Merged
merged 6 commits into from
Jun 5, 2023
Merged

fix: Fixes sharding placement algorithm and allows development of alternative algorithms #13018

merged 6 commits into from
Jun 5, 2023

Commits on Jun 5, 2023

  1. fix: Extraction of DistributionFunction to allow passing different ty… 

    …pe of functions to filter clusters by shard

- Adding unit tests for sharding
- Refresh clusters list on DistributionFunction call

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>
Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
    @akram
    akram committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9c7a15b View commit details
    Browse the repository at this point in the history

  2. fix: Incorrect conversion of an integer with architecture-dependent b… 

    …it size from [strconv.Atoi](1) to a lower bit size type uint32 without an upper bound check.

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>
    @akram
    akram committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    19f19d8 View commit details
    Browse the repository at this point in the history

  3. Added config to switch to round-robin sharding 

    Signed-off-by: Raghavi Shirur <rshirur@redhat.com>
Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>
    @raghavi101 @akram
    raghavi101 authored and akram committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    d4c18c8 View commit details
    Browse the repository at this point in the history

  4. Documenting sharding more, adding shuffling tests (skipped), re-enabl… 

    …e sharding algo env var

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>
    @akram
    akram committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    d395186 View commit details
    Browse the repository at this point in the history

  5. Allow configuration through argocd-cmd-params-cm configMap and key: c… 

    …ontroller.sharding.algorithm

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>
    @akram
    akram committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c7ea155 View commit details
    Browse the repository at this point in the history

  6. De-duplicate code, remove reflection for default case, shorten distri… 

    …bution methods name, ran codegen on manifests

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>

Signed-off-by: Akram Ben Aissi <akram.benaissi@gmail.com>
    @akram
    akram committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    095cb58 View commit details
    Browse the repository at this point in the history