-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix wrong link to non existing page for applicationset reference #13207
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13207 +/- ##
=======================================
Coverage 49.05% 49.05%
=======================================
Files 246 246
Lines 42569 42575 +6
=======================================
+ Hits 20882 20885 +3
- Misses 19572 19574 +2
- Partials 2115 2116 +1 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @thedatabaseme!
@thedatabaseme I would maybe update the title to "docs: Fix wrong link to non existing page for applicationset reference" |
done |
@thedatabaseme you also need to sign off on the DCO, please see https://github.com/argoproj/argo-cd/pull/13207/checks?check_run_id=12698099332 |
Signed-off-by: TheDatabaseMe <philip.haberkern@googlemail.com>
e98bde4
to
f8d1ebb
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @thedatabaseme!
/cherry-pick release-2.7 |
/cherry-pick release-2.6 |
/cherry-pick release-2.5 |
#13207) Signed-off-by: TheDatabaseMe <philip.haberkern@googlemail.com>
#13207) Signed-off-by: TheDatabaseMe <philip.haberkern@googlemail.com>
#13207) Signed-off-by: TheDatabaseMe <philip.haberkern@googlemail.com>
argoproj#13207) (argoproj#13247) Signed-off-by: TheDatabaseMe <philip.haberkern@googlemail.com> Co-authored-by: Philip Haberkern <59010269+thedatabaseme@users.noreply.github.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
argoproj#13207) Signed-off-by: TheDatabaseMe <philip.haberkern@googlemail.com>
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.
I've found a dead link within the RBAC docs which should reference to the applicationset/index.md but lead to nowhere.