fix(appset): Post selector with Go templates in ApplicationSet (cherry-pick #13584) #13823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roj#13584) * fixes argoproj#12524 Signed-off-by: Lewis Marsden-Lambert <lewis.lambert@zserve.co.uk> * refactor keepOnlyStringLabels function into more generic map flattening function Signed-off-by: Lewis Marsden-Lambert <lewis.lambert@zserve.co.uk> * updated USERS.md Signed-off-by: Lewis Marsden-Lambert <lewis.marsden-lambert@smartpension.co.uk> * use flatten library to replace custom flatten function Signed-off-by: Lewis Marsden-Lambert <lewis.marsden-lambert@smartpension.co.uk> --------- Signed-off-by: Lewis Marsden-Lambert <lewis.lambert@zserve.co.uk> Signed-off-by: Lewis Marsden-Lambert <lewis.marsden-lambert@smartpension.co.uk>
Signed-off-by: Lewis Marsden-Lambert <lewis.lambert@zserve.co.uk>
m13t
force-pushed
the
cherry-pick-release-2.6-13584
branch
from
58297e3
to
49f4ab4
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-2.6 #13823 +/- ##
===============================================
- Coverage 48.42% 48.42% -0.01%
===============================================
Files 247 247
Lines 41952 41961 +9
===============================================
+ Hits 20317 20319 +2
- Misses 19571 19577 +6
- Partials 2064 2065 +1
☔ View full report in Codecov by Sentry. |
crenshaw-dev
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(appset): Post selector with Go templates in ApplicationSet (#13584)