-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Patch Resource missing appNamespace (#13838) #13839
Conversation
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @speedfl!
/cherry-pick release-2.7 |
/cherry-pick release-2.6 |
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13839 +/- ##
=======================================
Coverage 49.25% 49.25%
=======================================
Files 251 251
Lines 43521 43521
=======================================
Hits 21435 21435
Misses 19951 19951
Partials 2135 2135 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
I deployed this version (v2.7.4) and I still get error on manifest editing. The application name is "prom-pushgateway" and it is deployed in "monitoring" namespace. ArgoCD still trys to lookup in "argocd" namespace as following logs show:
|
…oj#13840) Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com> Co-authored-by: Geoffrey MUSELLI <geoffrey.muselli@gmail.com> Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
Fixes #13838
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.