Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Patch Resource missing appNamespace (#13838) #13839

Merged
merged 3 commits into from
May 30, 2023

Conversation

speedfl
Copy link
Contributor

@speedfl speedfl commented May 30, 2023

Fixes #13838

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
@crenshaw-dev crenshaw-dev changed the title Fix(ui): Patch Resource missing appNamespace fix(ui): Patch Resource missing appNamespace (#13838) May 30, 2023
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @speedfl!

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 30, 2023 19:46
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.6

Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0eac769) 49.25% compared to head (3c13a98) 49.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13839   +/-   ##
=======================================
  Coverage   49.25%   49.25%           
=======================================
  Files         251      251           
  Lines       43521    43521           
=======================================
  Hits        21435    21435           
  Misses      19951    19951           
  Partials     2135     2135           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev crenshaw-dev merged commit 3ca9416 into argoproj:master May 30, 2023
22 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 30, 2023
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Jun 1, 2023
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
Co-authored-by: Geoffrey MUSELLI <geoffrey.muselli@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Jun 1, 2023
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
Co-authored-by: Geoffrey MUSELLI <geoffrey.muselli@gmail.com>
@asohnlein-tsy
Copy link

asohnlein-tsy commented Jun 6, 2023

I deployed this version (v2.7.4) and I still get error on manifest editing. The application name is "prom-pushgateway" and it is deployed in "monitoring" namespace. ArgoCD still trys to lookup in "argocd" namespace as following logs show:

time="2023-06-06T12:27:45Z" level=info msg="argocd v2.7.4+a33baa3.dirty serving on port 8080 
.
.
.
time="2023-06-06T12:28:56Z" level=warning msg="application does not exist" application=prom-pushgateway namespace=argocd
time="2023-06-06T12:28:56Z" level=warning msg="finished unary call with code PermissionDenied" error="rpc error: code = PermissionDenied desc = permission denied" grpc.code=PermissionDenied grpc.method=UpdateSpec grpc.service=application.ApplicationService grpc.start_time="2023-06-06T12:28:56Z" grpc.time_ms=6.295 span.kind=server system=grpc

schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
…oj#13840)

Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
Co-authored-by: Geoffrey MUSELLI <geoffrey.muselli@gmail.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Geoffrey Muselli <geoffrey.muselli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to patch resource using UI when using application in any namespace
3 participants