fix(ui): display valuesobject if set (cherry-pick #14257) #14755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(ui): display valuesobject if set (#14257)
With #11538 we now have the ability to set helm values as an object
instead of a string, but we also need to be able to correctly display
it in the UI if it is set.
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
If
valuesObject
is present, set it to the value ofinput.spec.source.helm.values
on save, as an unmarshaled json string.Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
helm.values
to empty string on saveIf
valuesObject
exists, setinput.spec.source.helm.values
to anempty string once
valuesObject
has been unmarshalled from thevalues input. This is to prevent unnecessary duplication of the values.
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
This is so that we can conditionally set
source.helm.values
withoutinadvertently affecting other parts of the app. Only when the edit
button is pressed do we toggle
source.helm.values
.Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com
Signed-off-by: Blake Pettersson blake.pettersson@gmail.com