Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appset): requeue ApplicationSet if there are validation errors (#14184) (cherry-pick #14429) #15206

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix: requeue ApplicationSet if there are validation errors (#14429)

Signed-off-by: Chetan Banavikalmutt chetanrns1997@gmail.com

Signed-off-by: Chetan Banavikalmutt <chetanrns1997@gmail.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (383f2a2) 49.90% compared to head (e5a5007) 49.91%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-2.8   #15206   +/-   ##
============================================
  Coverage        49.90%   49.91%           
============================================
  Files              263      263           
  Lines            45046    45051    +5     
============================================
+ Hits             22480    22485    +5     
  Misses           20355    20355           
  Partials          2211     2211           
Files Changed Coverage Δ
...cationset/controllers/applicationset_controller.go 62.82% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crenshaw-dev crenshaw-dev merged commit f070882 into release-2.8 Aug 24, 2023
19 of 22 checks passed
@crenshaw-dev crenshaw-dev deleted the cherry-pick-59b703-release-2.8 branch August 24, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants