fix(controller): add missing workqueue metrics (#16315) (cherry-pick #17013) #17209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcp-cherry-pick-bot[bot]](https://avatars.githubusercontent.com/in/169664?s=60&v=4){kind=small}
* fix(controller): add missing kubernetes metrics Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * validate workqueue metrics are present Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * use newer metrics registry Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix duplicated Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * init runtime controller in test to have correct metrics Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> * fix lint error Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> * update controller-runtime to remove metrics with high cardinality Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> --------- Signed-off-by: Alexandre Gaudreault <alexandre.gaudreault@logmein.com> Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
todaywasawesome
approved these changes
Feb 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.10 #17209 +/- ##
================================================
+ Coverage 49.71% 49.73% +0.01%
================================================
Files 272 271 -1
Lines 47964 47948 -16
================================================
- Hits 23847 23845 -2
+ Misses 21767 21753 -14
Partials 2350 2350 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked fix(controller): add missing workqueue metrics (#16315) (#17013)
Signed-off-by: Alexandre Gaudreault alexandre.gaudreault@logmein.com
Signed-off-by: Alexandre Gaudreault alexandre.gaudreault@logmein.com
Signed-off-by: Alexandre Gaudreault alexandre.gaudreault@logmein.com
Signed-off-by: Alexandre Gaudreault alexandre.gaudreault@logmein.com
Signed-off-by: Alexandre Gaudreault alexandre.gaudreault@logmein.com
Signed-off-by: Alexandre Gaudreault alexandre_gaudreault@intuit.com
Signed-off-by: Alexandre Gaudreault alexandre_gaudreault@intuit.com
Signed-off-by: Alexandre Gaudreault alexandre.gaudreault@logmein.com
Signed-off-by: Alexandre Gaudreault alexandre_gaudreault@intuit.com