Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list generator elements should be optional (cherry-pick #17424) #17510

Merged
merged 1 commit into from
Mar 28, 2024

Commits on Mar 13, 2024

  1. fix: elements should be optional (#17424)

    A bug was reported, where an applicationset with an empty elements
    array, when created with `argocd appset create <filename>.yaml` gets a
    `...list.elements: Required value` error.
    
    My hypothesis is that when calling the K8s API, golang JSON marshalling
    mangles the empty `elements` array to `nil`, rather than creating an
    empty array when submitting the `POST`.
    
    Still need to figure out why the same setup seemingly works fine when
    the same appset is in an app-of-apps.
    
    Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
    blakepettersson committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c95ce04 View commit details
    Browse the repository at this point in the history