Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix outdated slack notification configuration readme #17824

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

syscl
Copy link

@syscl syscl commented Apr 12, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: syscl <yating@deductive.ai>
@syscl syscl requested review from a team as code owners April 12, 2024 22:27
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to update the docs in the notifications package https://github.com/argoproj/notifications-engine and then update go mod to include the version of notifications that contains our change and run codegen to update argocd docs.

@pasha-codefresh
Copy link
Member

@syscl are you going to work on it ?

@syscl
Copy link
Author

syscl commented May 30, 2024

Hi @pasha-codefresh thank you for reminding, yes. Any extra steps still needs for the PR?

@pasha-codefresh
Copy link
Member

You need to do these changes inside notification-engine and after update notification-engine version inside go.mod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants