chore: improve codegen error output #17873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
pasha-codefresh
approved these changes
Apr 18, 2024
|
@crenshaw-dev lint check failed, PTAL |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…v/argo-cd into better-codegen-error Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
@pasha-codefresh fixed it, I'd accidentally committed an empty file :-) |
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
* chore: improve codegen error output Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * remove accidental file Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* chore: improve codegen error output Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * remove accidental file Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codegen
checkErrfunction currently hides any stderr output from a failed command. This change prints stderr for the failed command.