-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repo-server should allow not to skip hidden directories #17957
fix: repo-server should allow not to skip hidden directories #17957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this could be problematic for some users.
I'd recommend making global exclusions configurable via a glob pattern and defaulting to .*
.
I was thinking of adding a new flag ARGOCD_REPO_SERVER_INCLUDE_HIDDEN_DIRECTORIES that defaults to false to preserve the current behavior. |
Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
1267e29
to
6136f05
Compare
I've made the changes so it will not interrupt the current behavior as we've discussed using the |
@crenshaw-dev Can you please have a look? 🙏 |
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17957 +/- ##
==========================================
- Coverage 44.94% 44.93% -0.01%
==========================================
Files 354 354
Lines 47740 47742 +2
==========================================
- Hits 21455 21454 -1
- Misses 23482 23485 +3
Partials 2803 2803 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
…j#17957) * Update repository.go Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * add dir exclusion pattern Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> --------- Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> Co-authored-by: Bar <bar.ashkenazi@appsflyer.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…j#17957) * Update repository.go Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * add dir exclusion pattern Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> --------- Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> Co-authored-by: Bar <bar.ashkenazi@appsflyer.com>
…j#17957) * Update repository.go Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * add dir exclusion pattern Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> --------- Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> Co-authored-by: Bar <bar.ashkenazi@appsflyer.com>
…j#17957) * Update repository.go Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * add dir exclusion pattern Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> * support hidden directories in repo server Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> --------- Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com> Signed-off-by: Bar <bar.ashkenazi@appsflyer.com> Co-authored-by: Bar <bar.ashkenazi@appsflyer.com>
Currently, the repo-server skips hidden directories and there is no way to control it. the PR adds an option to include hidden directories.
Fixes #17915
Checklist: